Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Улучшение CI (комментирование inline) #365

Closed
ewgRa opened this issue Mar 24, 2018 · 2 comments
Closed

Улучшение CI (комментирование inline) #365

ewgRa opened this issue Mar 24, 2018 · 2 comments

Comments

@ewgRa
Copy link
Collaborator

ewgRa commented Mar 24, 2018 •
edited
Loading

Есть такая штука, houndci-bot.

Он при проверке, прям вставляет комментарии в diff PR, выглядит вот так: github.com/elastic/beats/pull/6641#pullrequestreview-106680439

Было бы круто, если CI чекер делал также.

Игнорил те строки, которые не изменились, а если нашел проблему в строке которая изменилась - вставлял комментарий прям в PR на определенную строку.
@ewgRa
Copy link
Collaborator Author

ewgRa commented Apr 30, 2018

https://developer.github.com/v3/pulls/comments/#create-a-comment

@ewgRa
Copy link
Collaborator Author

ewgRa commented May 6, 2018

implemented

@ewgRa ewgRa closed this as completed May 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ewgRa