Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox: Popout Player Window is Wrong Size #63

Closed
rthaut opened this issue Feb 23, 2019 · 1 comment
Closed

Firefox: Popout Player Window is Wrong Size #63

rthaut opened this issue Feb 23, 2019 · 1 comment

Comments

@rthaut
Copy link
Owner

rthaut commented Feb 23, 2019

In Firefox the popout player window is never opened at the correct size, regardless of configuration.

I thought this was just an issue when using percentage-based custom dimensions, but it occurs even when configured to use the original video player's size.

It seems to be using some default/fallback window size, as determined either by Firefox or the Operating System.

@rthaut rthaut added the bug label Feb 23, 2019
@rthaut
Copy link
Owner Author

rthaut commented Feb 23, 2019

This is caused by setting privacy.resistFingerprinting to true, although I haven't (yet) found proper documentation of this behavior anywhere.

It appears that enabling privacy.resistFingerprinting prevents windows.create() from actually using the supplied width and height properties (although curiously windows.update() does appear to use them).

Ideally it would be nice to detect this somehow (or detect the resulting incorrect functionality) and display a warning to the user, perhaps on the Options page and/or as a browser notification.

For now this should at least be documented on the Project Page as a FAQ and/or on the Options documentation page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant