Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Multi-Account Containers extension #104

Closed
Korko opened this issue Oct 23, 2019 · 1 comment · Fixed by #350
Closed

Handle Multi-Account Containers extension #104

Korko opened this issue Oct 23, 2019 · 1 comment · Fixed by #350

Comments

@Korko
Copy link

Korko commented Oct 23, 2019

Mozilla Firefox have an official extension called Multi-Account Containers allowing to have "categories" of tabs each having their separate cookies and so possibly a different account on each. https://github.com/mozilla/multi-account-containers/#readme

By default, YouTubePopupPlayer opens a tab without a specific container. It may be very interesting to keep the container of the original tab if possible.

@rthaut
Copy link
Owner

rthaut commented Oct 24, 2019

This is a great idea for an enhancement; thank you for the recommendation.

I know that a different container extension was causing the popout to be closed immediately (see #64), so any container-related changes should probably go through some extensive testing.

Here are my notes (for myself or someone else) for implementation ideas based on my initial investigation:

The documentation shows it is possible to open a new tab using a specific contextual identity (a.k.a. container), and it also appears to be possible to retrieve the contextual identity of the original/current tab.

The only downside to this approach is the "cookies" permission is needed to get/set the cookieStoreId property on tabs. Ideally this could be an optional permission for the Firefox build that is only requested when users "opt in" to enabling container support (likely via a new FF-only toggle switch on the Options panel), as I think many users would be apprehensive of using/updating the extension if the "cookies" permission was always required.

Alternatively, there might be a different way to open the popout so that the container extension(s) intercept the popout and handle it directly (like they do when clicking links on webpages within a container). However, based on the multitude of issues I ran into with other opening approaches during the version 3 rewrite, I'm fairly certain this won't be possible.

@rthaut rthaut mentioned this issue Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants