Remove haystack from code base #4039
Conversation
| @@ -84,9 +84,6 @@ def INSTALLED_APPS(self): # noqa | |||
| 'annoying', | |||
| 'django_extensions', | |||
| 'messages_extends', | |||
|
|
|||
| # daniellindsleyrocksdahouse | |||
| @@ -15,7 +14,7 @@ | |||
| <a href="{% if result.absolute_url %}{{ result.absolute_url }}{% else %}{{ result.object.get_absolute_url }}{% endif %}?highlight={{ query }}">{{ result.project }} - {{ result.title }}</a> | |||
| </p> | |||
| <p> | |||
| {% highlight result.text with query %} | |||
| {% result.text %} | |||
There was a problem hiding this comment.
We are losing some visual hints here
| @@ -55,7 +55,7 @@ <h5>{% trans "Filter by Project" %}</h5> | |||
| <a href="{% if result.absolute_url %}{{ result.absolute_url }}{% else %}{{ result.object.get_absolute_url }}{% endif %}?highlight={{ query }}">{{ result.project }} {% if result.version %} ({{ result.version }}) {% endif %} - {{ result.title }}</a> | |||
| </p> | |||
| <p> | |||
| {% highlight result.text with query %} | |||
| {% result.text %} | |||
| @@ -23,8 +23,6 @@ readthedocs-build<2.1 | |||
| # django-tastypie 0.13.x and 0.14.0 are not compatible with our code | |||
| django-tastypie==0.13.0 | |||
|
|
|||
| django-haystack==2.8.1 | |||
| celery-haystack==0.10 | |||
There was a problem hiding this comment.
I'm not sure where the celery-haystack was used, I assume it was some dependency from django-haystack
|
Travis is all green, that's a good sign 🍏 ...Or we don't have enough tests for apiv1 😨 |
|
haystack is not used for search results. The entire set of search templates referenced here can also be deleted, as our search results use |
This aren't used anymore, we use `readthedocs/templates/search/elastic_search.html`
|
I deleted the templates that were used previously, I checked the search pages and those work correctly and also I checked some endpoints and those are good too. |
|
Looks good. I'll give this a spin locally as well, but I don't forsee any issues since haystack hasn't been used in years. |
|
Looks good. Wee! |
Ok, this is a big remove (I'm more worried more about the apiv1 and some templates).
This closes #4006
RTD doesn't use haystack on production anymore. Also, I try some endpoints
Both give a 500 error code.
The only part that haystack was really being used was on some templates to use the
highlighthttps://django-haystack.readthedocs.io/en/master/templatetags.html#highlight tag, so, I'm not sure if it's good to remove this from here since it gives a nice visual hint for the user, maybe we can search another lib that gives the same functionality or maybe this isn't so relevant and we are ok removing it.Note: I wasn't able to full tests this on the search page with results because I don't have elasticsearch, I will try to setup elasticsearch to test this later.