Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small change to Chinese language names #3947

Merged
merged 2 commits into from
Apr 17, 2018
Merged

Small change to Chinese language names #3947

merged 2 commits into from
Apr 17, 2018

Conversation

davidfischer
Copy link
Contributor

Fix #3917

Django uses these names: https://github.com/django/django/blob/5b589a4/django/conf/global_settings.py#L139-L140

However, they use slightly different language codes. I don't think we need to make that change here.

@RichardLitt
Copy link
Member

However, they use slightly different language codes. I don't think we need to make that change here.

Can you specify what you mean by that?

@davidfischer
Copy link
Contributor Author

We use zh-cn and zh-tw. Django's default uses zh-hans and zh-hant.

@davidfischer davidfischer merged commit c46ae17 into readthedocs:master Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichardLitt RichardLitt RichardLitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidfischer @RichardLitt