-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show link to docs on a build #3446
Conversation
Build #{{ build_id }} | ||
{% endblocktrans %} | ||
</span> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how to do this on a better way, what js library are you using?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Knockout I believe.
Hope I didn't break any other parts with the css change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me in local testing. Will let @agjohnson comment on the HTML/JS stuff.
Build #{{ build_id }} | ||
{% endblocktrans %} | ||
</span> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Knockout I believe.
I think that with this change we are loosing some visual strengh impact on the status of the build when changing the red/green square by colorizing just the text I'd like to have the link Something like this: |
Visually, I prefer the change that @humitos suggests as well. Alternatively, the view docs link would also fit in the right float area nicely. My vote would be for adding the link to this section. My original thought is that we'd repurpose the main View Docs button, as it is really confusing that it always points to the same branch. This is another option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the technical side, these changes looks good 👍
The changes to revert the styling to the old UI will likely revert a lot of these additions however.
I reverted the other changes and put the link to the right as @agjohnson suggest On building stateNo staff userStaff user |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this new proposal!
This PR is related to readthedocs/ext-theme#278 and #2469
For now, I trying to solve this:
I think the
View Docs
button must remain the same on all the project area, otherwise it would be confusing.I don't know much css, so any feedback is more than welcome :).
Here is how it looks right now
And how it will looks like after merging
This is still very WIP, so any feedback and suggestion is welcome!