Link to version detail page from build detail page #3418
Conversation
| @@ -62,7 +63,11 @@ | |||
|
|
|||
| <div class="build-version"> | |||
| <span class="build-version-slug"> | |||
| {{ build.version.slug }} | |||
| {% if request.user|is_admin:project %} | |||
| <a href="{% url "project_version_detail" build.version.project.slug build.version.slug %}">{{ build.version.slug }}</a> | |||
There was a problem hiding this comment.
This should probably add an "Edit this version" link, not just link the actual version name.
There was a problem hiding this comment.
Yeah, I didn't know where/how to put to not break the style since the commit hash is already between parenthesis (and I like that) so, I was thinking on adding the "Edit this version" in the following line. What do you think?
There was a problem hiding this comment.
Example
0.14.4 (acbd8asd67a8761asvsd)
Edit this version
There was a problem hiding this comment.
I'd prefer the text link actually. "Edit this version" is a verbose addition. I think working a button into the interface is adding another design pattern to track. I'd rather revisit this when we have a better idea of what design patterns we're using on these interfaces.
humitos
force-pushed
the
humitos/build/link-version-detail
branch
from
508a7f0 to
b3274fb
Compare
|
Marking this as |
|
I think we should just merge it as is, and open another ticket for it. No reason to block this. |
On a build detail page, link the version detail page that it's being built if the user is the admin of the project, otherwise just show the slug as usual.
Related to #3417