Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running migration a 2nd time on an already migrated repository starts from scratch #44

Closed
WtfJoke opened this issue Aug 17, 2015 · 3 comments
Assignees
Labels

Comments

@WtfJoke
Copy link
Member

WtfJoke commented Aug 17, 2015

The situation was as follows:

  1. Complete migration of a stream worked flawlessly
  2. Couple days later, we wanted to keep up with the stream changes and ran the migration again
  3. For some reason, the migration didnt continue and started from 0/the beginning instead

Analysis
We figured out, that the workspace was reset to the oldest state.

Cause
The reason was that the only baseline on this stream didnt contain anything (Initial Baseline).
This means, setting the components to the baseline durnig the migration will reset the whole workspace, therefore resetting the migrated workspace.

The 2nd run of the migration triggered a reset of the components to the baseline.

Solution
Luckily we can detect this situation. If the part until the baseline creation is already migrated, we dont have any changesets to get accepted.

Therefore if we have 0 changesets to accept until the branchpoint, we just dont do anything there and continue with the comparing from the workspace with the stream

@romixch : You can link your commit/fix to this issue
@romixch @ohumbel : I created this issue for documentation purpose

@ohumbel
Copy link
Member

ohumbel commented Aug 21, 2015

this was fixed with 0a750ff

@ohumbel ohumbel closed this as completed Aug 21, 2015
@WtfJoke
Copy link
Member Author

WtfJoke commented Aug 22, 2015

I think the solution has a small flaw. When you have problems while accepting the changes of the stream (https://github.com/rtcTo/rtc2git/blob/develop/migration.py#L76) and then restart it, it will skip those changes.

@ohumbel
Copy link
Member

ohumbel commented Aug 26, 2015

The flaw should be fixed with b568a24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants