Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make encoding configurable #30

Closed
WtfJoke opened this issue Jun 8, 2015 · 2 comments
Closed

Make encoding configurable #30

WtfJoke opened this issue Jun 8, 2015 · 2 comments
Assignees

Comments

@WtfJoke
Copy link
Member

WtfJoke commented Jun 8, 2015

The encoding should be configurable. If nothing is configured, the default encoding should be used (encoding = None).

This issue is resolved when the encoding is configurable in the config and a wiki-entry has been made about how to configure the encoding properly with the magic.properties

See discussion #26 (comment)

@WtfJoke
Copy link
Member Author

WtfJoke commented Jun 9, 2015

Wiki-Entry can be found here: https://github.com/WtfJoke/rtc2git/wiki/Encoding

@Cloud-Forge
Copy link

Hi,

in shell.py line 23 :
output = outputasbytestring.decode(sys.stdout.encoding).splitlines()
throw an error of the type :

UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe9 in position 224: inval d continuation byte

even though the encoding in the config.in file is not set as utf-8.

To circumvent the issue I had to add :
sys.stdout.reconfigure(encoding=generalsection.get('encoding'))
in configuration.py line 38, so the sys encoding is set properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants