Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTC-Switch example inconsistent with this code. #6

Open
Neograph734 opened this issue Jun 29, 2015 · 2 comments
Open

RTC-Switch example inconsistent with this code. #6

Neograph734 opened this issue Jun 29, 2015 · 2 comments
Assignees

Comments

@Neograph734
Copy link
Contributor

The provided sample on https://github.com/rtc-io/rtc-switch appears to be incompatible with this code.

The script here emits messages always as 'rtc-signal' event. (line 42). But the example on https://github.com/rtc-io/rtc-switch listens to 'message'.

Perhaps it is an idea to make the event as an option, so one can choose it? And make both examples use one event for consistency?

@Neograph734 Neograph734 changed the title The sample provided on https://github.com/rtc-io/rtc-switch RTC-Switch example inconsistent with this code. Jun 29, 2015
@DamonOehlman
Copy link
Member

Thanks @Neograph734 - we should definitely make the events consistent. Adding this to my TODO list :)

@DamonOehlman DamonOehlman self-assigned this Jul 4, 2015
@magestican
Copy link

For those of you looking at this in 2016 and running into issues, you must listen for rtc-signal not message on your server socket if you want to tap into the connection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants