-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ROS 2 #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
display.launch.pyの動作確認できました。READMEの表記が気になったためコメントしました。
README.md
Outdated
|
||
## インストール方法 | ||
|
||
```sh | ||
# 本パッケージをクローンし、依存関係をインストールする | ||
cd ~/catkin_ws/src | ||
git clone https://github.com/rt-net/crane_x7_description | ||
mkdir -p ~/dev_ws/src |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここってdev_wsでいいですか?ros2_ws等の名前である必要はないですか?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ros2_wsに修正します。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ROS 2 Dashing公式ドキュメントではdev_ws使っているので、その名残ですね。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
確認しました。問題ないです。
What does this implement/fix?
ROS 2に対応します。
パッケージ依存関係の都合上foxyとrollingには対応していません。
CIからも除外しています。
Does this close any currently open issues?
いいえ
How has this been tested?
CIでビルドが通ることを確認しています。
display.launch.pyが動作することを確認しています。
Checklists