Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ROS 2 #3

Merged
merged 8 commits into from
Sep 5, 2022
Merged

Support ROS 2 #3

merged 8 commits into from
Sep 5, 2022

Conversation

ShotaAk
Copy link

@ShotaAk ShotaAk commented Sep 5, 2022

What does this implement/fix?

ROS 2に対応します。

パッケージ依存関係の都合上foxyとrollingには対応していません。
CIからも除外しています。

Does this close any currently open issues?

いいえ

How has this been tested?

CIでビルドが通ることを確認しています。

display.launch.pyが動作することを確認しています。

Checklists

@ShotaAk ShotaAk added the Type: Feature New Feature label Sep 5, 2022
@ShotaAk ShotaAk changed the base branch from master to ros2 September 5, 2022 06:34
@ShotaAk ShotaAk requested a review from Kuwamai September 5, 2022 06:40
@ShotaAk ShotaAk marked this pull request as ready for review September 5, 2022 06:40
Copy link
Contributor

@Kuwamai Kuwamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

display.launch.pyの動作確認できました。READMEの表記が気になったためコメントしました。

README.md Outdated

## インストール方法

```sh
# 本パッケージをクローンし、依存関係をインストールする
cd ~/catkin_ws/src
git clone https://github.com/rt-net/crane_x7_description
mkdir -p ~/dev_ws/src
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここってdev_wsでいいですか?ros2_ws等の名前である必要はないですか?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ros2_wsに修正します。

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ROS 2 Dashing公式ドキュメントではdev_ws使っているので、その名残ですね。

@Kuwamai Kuwamai self-requested a review September 5, 2022 07:21
Copy link
Contributor

@Kuwamai Kuwamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認しました。問題ないです。

@Kuwamai Kuwamai merged commit f5c8554 into ros2 Sep 5, 2022
@Kuwamai Kuwamai deleted the ros2-devel branch September 5, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants