Structure updates and internal documentation improvements #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actory() function payload
…to be declared in the infoFactory function.
…overed by the list-type.
❌ Deploy Preview for shinyuieditor-storybook failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mostly merges how nodes are defined. Previously node definitions were split into "information" and "rendering" parts. This was due to the mono repo previously having a separate package for node info definitions. The problem is this was super confusing and only for historical reasons. So after an unreasonably large set of diffs, the info and rendering are all declared in a single large object. Because this object is large and relatively nuanced, there is now a readme file explaining what goes into it in the
ui_node_definitionsdirectory.