Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHA: 026-shiny-inline test failures with rendering bold text #199

Closed
MadhulikaTanuboddi opened this issue Dec 21, 2021 · 4 comments
Closed

GHA: 026-shiny-inline test failures with rendering bold text #199

MadhulikaTanuboddi opened this issue Dec 21, 2021 · 4 comments
Assignees
@cpsievert @MadhulikaTanuboddi
Labels
QA InProgress Testing/Verification in progress

Comments

@MadhulikaTanuboddi
Copy link
Contributor

https://github.com/rstudio/shinycoreci-apps/tree/main/apps/026-shiny-inline app does not render the bolded text correctly since the change with rstudio/htmltools@72cc41e.

Shinytest tests were failing due to the same.

026-shiny-inline-htmltools-bold-text
@MadhulikaTanuboddi
Copy link
Contributor Author

MadhulikaTanuboddi commented Dec 21, 2021 •
edited
Loading

Introduced by rstudio/htmltools#306 and Should be fixed by rstudio/htmltools#308

@MadhulikaTanuboddi
Copy link
Contributor Author

Verified on 12/21- Not fixed yet. checking with Carson

@MadhulikaTanuboddi MadhulikaTanuboddi added the QA InProgress Testing/Verification in progress label Dec 21, 2021
@cpsievert
Copy link
Contributor

Thanks @MadhulikaTanuboddi, looks like rstudio/htmltools#308 fixed the issue for statically rendered inline code blocks, but looks like Shiny will need a change to fix it for dynamically rendered ones

@cpsievert cpsievert mentioned this issue Jan 10, 2022
Closed
@cpsievert
Copy link
Contributor

Let's track this issue via rstudio/shiny#3568 instead of here.

(I'll update the Trello card to point to the Shiny issue/PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpsievert cpsievert

@MadhulikaTanuboddi MadhulikaTanuboddi

Labels
QA InProgress Testing/Verification in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cpsievert @MadhulikaTanuboddi