Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: re-deploys to shinyapps.io from stateless environments fail #932

Closed
mbaynton opened this issue Jul 26, 2023 · 2 comments · Fixed by #933
Closed

Regression: re-deploys to shinyapps.io from stateless environments fail #932

mbaynton opened this issue Jul 26, 2023 · 2 comments · Fixed by #933
Assignees

Comments

@mbaynton
Copy link
Contributor

As of 1.0.0 (probably specifically 25b93da), users who deploy updates to applications on shinyapps.io through automated processes such as CI environments that don't preserve the rsconnect state files are experiencing the following failure:

> rsconnect::deployApp('source-directory')
── Preparing for deployment ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
✔ Deploying "soshiny" to "server: shinyapps.io / username: e5c2wc-mike-baynton"
ℹ Creating application on server...
Error in `POST()`:
! <https://api.shinyapps.io/v1/applications/> failed with HTTP status 409
Application exists with name: soshiny
Run `rlang::last_trace()` to see where the error occurred.
@aronatkins
Copy link
Contributor

Should #808 have been addressed only for posit.cloud and not shinyapps.io?

The #831 work used isCloudServer(), which excludes both posit.cloud and shinyapps.io.

if (!isCloudServer(fullAccount$server)) {

@mbaynton are you able to try switching this logic to use isPositCloudServer()?

rsconnect/R/servers.R

Lines 63 to 73 in 02cada1

isShinyappsServer <- function(server) {
identical(server, "shinyapps.io")
}
isPositCloudServer <- function(server) {
server %in% c("posit.cloud", "rstudio.cloud")
}
isCloudServer <- function(server) {
isPositCloudServer(server) || isShinyappsServer(server)
}

@mbaynton
Copy link
Contributor Author

Should #808 have been addressed only for posit.cloud and not shinyapps.io?

Yes, @mslynch's fix is what I expected to be the right fix. (Sorry I wasn't able to be more interactive here, @mslynch's team is focusing on rsconnect this quarter.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants