Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test compatibility with python pins #610

Closed
machow opened this issue Apr 14, 2022 · 2 comments · Fixed by #740
Closed

Test compatibility with python pins #610

machow opened this issue Apr 14, 2022 · 2 comments · Fixed by #740

Comments

@machow
Copy link
Collaborator

machow commented Apr 14, 2022

From discussion with @juliasilge, let's set up a github action to ensure that changes made to R pins are compatible with the current version of python. E.g. save the pins from R, and the run py pins to ensure it can read, search, list, etc..

@juliasilge
Copy link
Member

We never did set up cross-language testing to read from a board created by the other side, to read a pin created from the other side, etc. Let's figure out why we would see a warning:

In python:

from dotenv import load_dotenv
load_dotenv()
from pins import board_s3
from pins.tests.helpers import BoardBuilder

bb = BoardBuilder("s3")
board = bb.create_tmp_board("pins/tests/pins-compat")

# list path to temporary pins bucket, for copying into R
board.board

Switching to R:

board <- board_s3(<bucket_from_above>, prefix="<prefix_from_above>/")

# note that this also prints a warning
board %>% board_manifest()

Originally posted by @machow in #661 (comment)

@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants