Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit mechanism for turning off versioning on rsconnect boards #324

Closed
colearendt opened this issue Dec 14, 2020 · 3 comments
Closed

Revisit mechanism for turning off versioning on rsconnect boards #324

colearendt opened this issue Dec 14, 2020 · 3 comments
Assignees

Comments

@colearendt
Copy link
Contributor

In #245 , there is an implementation that consists of delete the content.

IMO, we should be more judicious about deleting / recreating content, and instead purge old bundles using the bundle API. This way links / etc. are not broken

@javierluraschi
Copy link
Contributor

Hi @colearendt,

Are we already doing this? See https://github.com/rstudio/pins/blob/master/R/board_rsconnect.R#L216-L222

So basically, we query the previous bundle versions, and we delete all the previous ones except the current one. Are we perhaps using an older version of pins?

@colearendt
Copy link
Contributor Author

Ahh nice, thanks! That's perfect - I missed that! I was distracted by https://github.com/rstudio/pins/blob/2944c532b599dff83061942e1f9f9717abd4cb7f/R/board_rsconnect.R#L376 😅

Thanks Javier!!

@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants