Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose 10 second timeout as option #22

Closed
dpastoor opened this issue Jan 25, 2020 · 2 comments · Fixed by #120
Closed

expose 10 second timeout as option #22

dpastoor opened this issue Jan 25, 2020 · 2 comments · Fixed by #120

Comments

@dpastoor
Copy link

I know 10 seconds feels like a long time, but here is the issue we are currently facing:

On newly provisioned AMI's, chrome can take closer to 15-20 seconds to launch the first time the ami is run, hence we are continually running into the timeout error on https://github.com/rstudio/chromote/blob/master/R/chromote.R#L62

It would be great to expose this as an option (and I'd be happy to add as a PR), so for those of us sorry souls that have to wait that long the first time this doesn't force other workarounds.

 p <- promise_resolve(TRUE)$
          then(function(value) {
            promise_timeout(
              promise(function(resolve, reject) {
                private$ws$onOpen(resolve)
              }),
-              10,
+              getOption("chromote.websocket_timeout", 10),
              timeout_message = "Chromote: timed out waiting for WebSocket connection to browser."
            )
          })
@bschilder
Copy link

+1

@dpastoor
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants