This repository has been archived by the owner on Nov 30, 2024. It is now read-only.
Any instance expectations with super/sub classes and nested blocks leak stubs. #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello Jon How do you want to proceed? This PR needs the fix too? Thanks |
|
@benoittgt This PR is just demonstrating the issue, it still needs fixing. |
JonRowe
force-pushed
the
any_instance_nested_call_error
branch
from
1257e1f
to
03654bc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using nested method calls and blocks, stubbing a super class method will leak into the child class for the duration of the block. First reported on rspec/rspec-core#2563 (with reproduction over at https://github.com/jcavalieri/rspec_issue).
Attached commit demonstrates the issue.