Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stat counter glitch caused by the restart #1773

Closed
vthriller opened this issue Jul 27, 2017 · 1 comment
Closed

stat counter glitch caused by the restart #1773

vthriller opened this issue Jul 27, 2017 · 1 comment
Labels

Comments

@vthriller
Copy link

vthriller commented Jul 27, 2017

Classification (Please choose one option):

Other bug

Reproducibility (Please choose one option):

Sometimes

Rspamd version:

1.6.2, 1.7.0-git.8802590ef

Operation system, CPU, memory and environment:

Ubuntu 14.04

Description (Please provide a descriptive summary of the issue):

Counters acquired through the /stat are sometimes getting slightly backtracked after restart. This can be seen with external monitoring system that collects its output (Prometheus in this case):
2017-07-27-200824_1680x1050_scrot

This is a problem for a wide range of tools from e.g. rrdtool (through COUNTER) to Prometheus (rate()), as they consider backtracking as a reset counter and adjust to that accordingly:

2017-07-27-200836_1680x1050_scrot

Not all restarts are causing that though.

There are two possible solutions here:

  • try harder keeping counter values through restarts,
  • reset counters to 0 altogether with every restart (any descent monitoring system will cope with that just fine).

Steps to reproduce:

service rspamd restart

@stale
Copy link

stale bot commented Mar 25, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 25, 2019
@stale stale bot closed this as completed Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant