-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load balancer throwing several exceptions when refreshing available sockets #786
Comments
I think the issue is related to the warning in https://docs.oracle.com/javase/tutorial/essential/concurrency/syncmeth.html |
Hi @PMacho! Thanks for letting us know! We will be reworking Loadbalanced RSocket for 1.1 release. Cheers, |
Hi @OlegDokuka, I actually don't think, it is the same issue. In #716 the point is that no renewal happens at all (which, if I should guess, is probably related to As I mentioned already this is probably related to the List I could help solving this issue, if you are interested. Best, Peter |
@PMacho PRs are welcome. In general, all the open issues related to LoadBalancedRSocket has the same root-cause - improper implementation and improper concurrency handling. Please keep in mind that the However, please do not give up and try to fix your findings and send your proposal! Cheers, |
@OlegDokuka yeah, honestly I didn't want to say it that way, but yes I also think so. The |
Also, you may find useful this PR from which you may take some ideas #685 |
Thank you, I'll have a look at it. |
Hi, I did some work, trying to make the socket pooling/selection reactive (without synchronized methods). An unordered snapshot can be viewed on my github page, the main entry point is LoadBalancedRSocket. I however came across quite some issues. I'd like to have a bit of discussion with someone before investigating too much time into things, that might not be accepted later. (I am quite new on github and do not really know the normal workflow.) My questions include but are not limited to:
Note: In case you want to have a look at my fork, I am not done and I didn't investigate into testing yet. |
Hey. I also started to reimplement LoadbalancingRSocket on my own. if you wish we can have a call and discuss all these questions |
Ok we definitely should. Otherwise, we’ll do the work twice. How can I reach you? |
Please drop me a message at https://twitter.com/OlehDokuka |
@OlegDokuka at my current job we were studying the possibility of adding the load balancer to our code (it provides useful features that we would like to use) but we stopped due mostly to the issue reported in issue #713
Cheers, |
@PaoloTheKillah We are planning to have a 1.1-M1 release on the 1st of August. In the good case, rework related to loadbalancer will go in that release. In the worse case - it is going to be M2 which is planned on the beginning of September |
@OlegDokuka that's great news! thanks for the prompt response :) |
@PMacho we have finally introduced new implementation. Would you like to play with it and see whether it has to be improved? |
Hi @OlegDokuka, nice to jetzt from you. I'll sure look at the new implementation as soon as possible and send a feedback. |
should be closed by #953 |
I wanted to use the LoadBalancedRSocketMono in combination with springs ReactiveDiscoveryClient, but this doesn't work well at present.
The behaviour can be simulated by added the following to LoadBalancedRSocketMonoTest:
This test basically works, however from time to time it throws two different exceptions:
The text was updated successfully, but these errors were encountered: