Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings in 9.0? #33

Open
shanemileham opened this issue Apr 26, 2016 · 3 comments
Open

Deprecation warnings in 9.0? #33

shanemileham opened this issue Apr 26, 2016 · 3 comments
Assignees

Comments

@shanemileham
Copy link

In my project running 9.0, I imported ClusterPrePermissions, but I got dozens of warnings of deprecations (UIAlertView, ALAuthorizationStatus, ALAssetsLibrary, etc.). I'm not sure how open source code is supposed to deal with OS version changes, so what is the best way to deal with this, and does this warrant an issue in the future? Thanks.

@rsattar
Copy link
Owner

rsattar commented Apr 26, 2016

Hey @shanemileham you're not wrong, ClusterPrePermissions still uses the older dialog system to be compatible with iOS 7. If we drop iOS 7 support, it would be a big rewrite to convert everything over to UIAlertController, Photos framework, etc.

The changes between iOS 7 and 8 are big enough to warrant a big cleanup of the code. How do people feel about dropping iOS 7 at this point?

@rsattar rsattar self-assigned this Apr 26, 2016
@jesster2k10
Copy link

I think we should drop iOS 7.0 Support, after all it seems apple are not even supporting it anymore. Also Swift support should be considered, I'll try port some code over myself and see. You're using outdated push notification calls for iOS 10.0. You should use the UserNotifications Framework

@rsattar
Copy link
Owner

rsattar commented Mar 5, 2017

I think you're right about dropping iOS 7 support. Not to mention now that Xcode/Apple will complain if you have code for a particular framework but don't have a proper usage description in your Info.plist file.

However, as much as I love Swift (and I wish I could write everything in it), I switching to Swift would introduce new headaches in maintaining this library. Even though after Swift 3, we're mostly source-stable, it's still going to be an issue supporting different Swift versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants