-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does It is possible to provide allowedOrigin patterns? #193
Comments
The README says
|
My example is Spring pattern https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/web/cors/CorsConfiguration.html#setAllowedOriginPatterns(java.util.List)
Yes. See my current development config allowed_origins:
- https://*.mysite.com
- http://localhost:4100
- http://localhost:4200
- http://localhost:4300
- http://localhost:4400
- http://127.0.0.1:4100
- http://127.0.0.1:4200
- http://127.0.0.1:4300
- http://127.0.0.1:4400 |
The same origin patterns would work with rs/cors. What's the problem? Were you hoping that you could express your desired allowed origins more easily with rs/cors than with Spring? I'm not very familiar with Spring, but I don't think that's possible. |
Looks like no problem if rs/cors will unwrap
to
|
I'm aware of Spring (of course) but I didn't know that it supported such an origin pattern. Interesting.
Ok, but different CORS libraries from different ecosystems support different origin patterns. I don't think the goal of rs/cors is to cater for developers coming from all those other ecosystems. Those developers simply need to take the time to read the documentation in order to figure out what's possible or not.
If |
Or smth like this?
The text was updated successfully, but these errors were encountered: