Delay the loading of the placeholder image until after load #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why don't you use the |
|
I didn't want to interfere with the existing setup. But that would be a better option. Is this something you'd prefer to see and would consider merging? |
|
Definitely |
|
@rs I think this pull request was updated according to your feedback. Could you please take a look and merge if you agree? It looks good to me |
rs
pushed a commit
that referenced
this pull request
Jun 12, 2014
Delay the loading of the placeholder image until after load
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some categories that build upon this that have activity spinners or other loading images that are separate from the placeholder image. I overloaded the -setImageWithURL method to provide a delayPlaceholder flag that will load the placeholder image only after the image fails to load. This allows the activity spinner or loading image to show rather than the placeholder image.