Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Addition of flag maskAllText #1563

Open
1 task done
chetan-187 opened this issue Sep 4, 2024 · 2 comments
Open
1 task done

[Feature Request]: Addition of flag maskAllText #1563

chetan-187 opened this issue Sep 4, 2024 · 2 comments
Labels
feature request Things want to be added

Comments

@chetan-187
Copy link

Preflight Checklist

  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

What package is this feature request for?

rrweb

Problem Description

If I want to mask all text on the DOM it takes me to implement a function and do additional efforts. The addition of maskAllText flag with make it as is as it does for maskAllInputs

Proposed Solution

Solution is I should be able to pass a option maskAllText while initializing rrweb, and it shoud replace all text from DOM with *

Alternatives Considered

The alternative feature is implementing maskInputFn

Additional Information

This feature would be really helpful as to mask the DOM data is sometimes need for financial or security businesses.

@chetan-187 chetan-187 added the feature request Things want to be added label Sep 4, 2024
@kmlwlkwk
Copy link
Contributor

kmlwlkwk commented Sep 5, 2024

We did implementation of masking all text but it might be very expensive and you need to be very careful

@chetan-187
Copy link
Author

Hey @kmlwlkwk, can you please explain in which sense it will be expensive and what are the critical things?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Things want to be added
Projects
None yet
Development

No branches or pull requests

2 participants