Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not compile with glibc >= 2.28 #11

Closed
blackPantherOS opened this issue Sep 21, 2018 · 5 comments
Closed

Does not compile with glibc >= 2.28 #11

blackPantherOS opened this issue Sep 21, 2018 · 5 comments

Comments

@blackPantherOS
Copy link

Changes in glibc 2.28 will breaks this application build,

make all-recursive
make[3]: Entering directory '/usr/src/RPM/BUILD/recode-3.7/lib'
make[4]: Entering directory '/usr/src/RPM/BUILD/recode-3.7/lib'
/bin/sh ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I.. -O2 -g -pipe -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -D_REENTRANT -fPIC -MT fseterr.lo -MD -MP -MF .deps/fseterr.Tpo -c -o fseterr.lo fseterr.c
libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -O2 -g -pipe -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector --param=ssp-buffer-size=4 -D_REENTRANT -fPIC -MT fseterr.lo -MD -MP -MF .deps/fseterr.Tpo -c fseterr.c -fPIC -DPIC -o .libs/fseterr.o
fseterr.c: In function ‘fseterr’:
fseterr.c:78:3: error: #error "Please port gnulib fseterr.c to your platform! Look at the definitions of ferror and clearerr on your system, then report this to bug-gnulib."
#error "Please port gnulib fseterr.c to your platform! Look at the definitions of ferror and clearerr on your system, then report this to bug-gnulib."
^~~~~
@rrthomas
Copy link
Owner

Thanks for the heads up. The fix is to update gnulib. I will make a new source release with updated gnulib.

@rrthomas
Copy link
Owner

rrthomas commented Sep 22, 2018 •
edited
Loading

I've just pushed an update to gnulib that should fix this.

Could you possibly build from git master to check that it does?

@rrthomas rrthomas reopened this Sep 22, 2018
@blackPantherOS
Copy link
Author

I will check today, thank you

@blackPantherOS
Copy link
Author

Okay now, the build is working fine new updated gnulib.

@rrthomas
Copy link
Owner

Thanks for confirming. I've released 3.7.1, with no other changes but the updated gnulib.

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue May 18, 2023
@0-wiz-0
recode: update to 3.7.14.
7915e3f 
Version 3.7.14
==============


+ No user-visible changes; minor clean-ups as part of the Debian
  packaging process.


Version 3.7.13
==============


+ Fix request diagnostics with --verbose: avoid output of confusing and
  possibly incorrect diagnostics.
+ Fix a file descriptor leak.


Version 3.7.12
==============


+ Simplify support for ignoring invalid input with iconv, integrated with
  the --strict and --force mechanisms.
+ Various documentation improvements.


Version 3.7.11
==============


+ Re-add support for transliteration with iconv (removed in 3.7).
+ Add support for ignoring invalid input with iconv.
+ Fix a bug introduced in 3.7.10 that prevented building the code.


Version 3.7.10
==============


+ In recode program, only use iconv if needed; add --prefer-iconv option to
  allow its use in all cases.
+ Remove support for pre-3.5 request syntax (colon as charset separator).
+ PO files have been updated from the Translation Project.
+ Build system fixes and improvements.
+ Update gnulib to fix a problem building on Android.
+ Fix confusingly wrong NEWS entry for 3.7.4.


Version 3.7.9
=============


+ A fix to the CP1252 encoding: U+017E LATIN SMALL LETTER Z WITH CARON is at
  byte 0x9e, not byte 0x8f.
+ Minor documentation fixes.


Version 3.7.8
=============


+ Improvements to the build system.
+ Fix man page generation, and document that help2man must be built with
  gettext.
+ Updates to nl, pt, sv translations (thanks, translators!).


Version 3.7.7
=============


+ Improvements to the build system.
+ Updates to nl, pt, sv translations (thanks, translators!).


Version 3.7.6
=============


+ Improvements to the build system.


Version 3.7.5
=============


+ Port tests to Python 3.


Version 3.7.4
=============


+ Fixes to file handling in recode program.
+ Fix tests on Windows.


Version 3.7.3
=============


+ No code changes to recode itself; this release features a properly
versioned shared library.


Version 3.7.2
=============


+ No code changes to recode itself; this release includes updates to license
headers to guide users to the GPL online, corrects the version of
COPYING-LIB shipped with the sources, and updates the message files for
various languages.


Version 3.7.1
=============


+ No code changes to recode itself; this release just updates the version of
gnulib to fix a bug in glibc 2.28: (GitHub issue #11
rrthomas/recode#11


Version 3.7
===========


+ Converters for BibTeX (from Vincent Danjean) and the ANSEL and ISO 5426
  character sets (from Wolfram Schneider) have been added.
+ The conversion strategies (whether to use pipes, memory or files) are
  no longer available.  Now it is reasonable to assume virtual memory, so
  files and memory have similar performance characteristics (in
  particular, the memory method is not limited by physical memory.)
  Further, tests showed that even for runs on little data, the pipes
  method has minimal performance impact (none was measured).  This is
  not a surprise, as for one-step recodings, the commonest case, no
  forking is needed.  The command-line options -i, -p and
  --sequence=STRATEGY are ignored for backwards compatibility.
+ Recode does not include libiconv anymore, but uses an external iconv
  library if one was available at installation time.  The -x: option
  to the program, or a new flag to the library recode_new_outer
  function, inhibits the initialisation and usage of iconv.
+ The experimental ``tree`` surface is removed.  Structured data
  needs a proper parser, and that doesn't fit the framework of Recode.
+ Many bug fixes.
+ Long ago, I renamed GNU recode to Free recode: the permission for
  using the GNU prefix mandated a level of obedience to the FSF that
  once went overboard, in my opinion.  After that change, I realized
  that some people read Free as a four letter word!  To be peaceful,
  this version changes the name again, to merely Recode.  recode
  (no capital) still names the executable program specifically, or
  the distribution archive itself.
+ make check accepts a LIMIT= option, for limiting tests to one or a
  few cases.  See tests/Makefile.am.
+ PO files have been updated from the Translation Project.
+ The test system has been overhauled.  Tests now run much faster, and
  require Python and Cython.
+ Overhauled build system, now using gnulib for portability.  This reduces
  the amount of code in the Recode tree considerably.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rrthomas @blackPantherOS