Skip to content
This repository has been archived by the owner on Dec 3, 2018. It is now read-only.

Read bs-config instead of having webpack options #26

Closed
arnarthor opened this issue Sep 6, 2017 · 3 comments
Closed

Read bs-config instead of having webpack options #26

arnarthor opened this issue Sep 6, 2017 · 3 comments
Assignees

Comments

@arnarthor
Copy link
Collaborator

By reading the bsconfig we could skip the options part of webpack.

The downside would be that bsconfig supports trailing commas and comments in JSON which we don't have access to AFAIK.

I would really love this, since it could allow users to pick their style when using reason-scripts witouth ejecting it also prevents non reason-scripts users from making simple mistakes like, updating the options in webpack but not their bsconfig.

Do you have any thoughts on this @rrdelaney

@rrdelaney
Copy link
Owner

Sounds good 😄 I'm starting work on this now, just wrote a quick lib to read a bsconfig.json from a dir: https://github.com/rrdelaney/read-bsconfig

@rrdelaney rrdelaney self-assigned this Sep 6, 2017
@arnarthor
Copy link
Collaborator Author

Awesome! Feel free to ping me if you want help with this, it should be pretty straight forward, but if you need extra time or eyes I'm available 👍

@rrdelaney
Copy link
Owner

This was fixed by #27

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants