Skip to content
This repository has been archived by the owner on Aug 12, 2020. It is now read-only.

Code Coverage #15

Open
CodeLenny opened this issue Aug 6, 2017 · 5 comments
Open

Code Coverage #15

CodeLenny opened this issue Aug 6, 2017 · 5 comments

Comments

@CodeLenny
Copy link
Collaborator

I'm not the biggest fan of using code coverage to drive development, but I sometimes reference the report to make sure that tests hit what is expected.

Codecov is simple to setup, while Code Climate also deals with code linting.

@rrdelaney would you like one of these configured for ava-rethinkdb?

@rrdelaney
Copy link
Owner

I've used Coveralls before with good results. Would that be good?

@CodeLenny
Copy link
Collaborator Author

I've tried both Codecov and Coveralls. Personally, I prefer Codecov:

  • Merges results from each Travis build, instead of only accepting one
  • Provides more data in PRs, if that's good or bad (Codecov vs coveralls)

And I think I prefer the dashboard a little better than coveralls, but they're pretty similar.

So really, I could go either way!

@rrdelaney
Copy link
Owner

I haven't used either in forever, but Codecov seems fine 👍 Let's get the Travis tests to pass before setting it up though

@CodeLenny
Copy link
Collaborator Author

Sure!

@CodeLenny
Copy link
Collaborator Author

Actually, on second thought, I might take that back. I might be able to use code coverage (if available) to steer testing in #12, just to make sure that everything gets sufficiently hit.

We could quickly use .failing() from AVA to get CI into a "successful" state, but clearly mark that progress is still needed.

Then we could quickly implement code coverage, and use both in #12.

I don't need coverage, so we could wait, but I don't see much advantage to not having it sooner.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants