Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new rule rrd expressioninvfor #385

Merged
merged 7 commits into from
Oct 7, 2024

Conversation

rrd108
Copy link
Owner

@rrd108 rrd108 commented Oct 7, 2024

Summary

New rule for expressions in v-for

Description

Expressions in v-for shoul be refactored into a computed property

Related Issues

Fixes #337

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Documentation update

@rrd108 rrd108 requested a review from David-Pena October 7, 2024 19:28
Copy link

github-actions bot commented Oct 7, 2024

logo Vue Mess Detector Analysis Results

PR Code Health Full Code Health

🚨 New Errors: 6
⚠️ New Warnings: 27
✅ Fixed Errors: 1
🔧 Fixed Warnings: 21
📝 Total Lines: 730
📁 Total Files: 8

New Issues

- src/cli.test.ts:
  rrd ~ function size: function (runCLI#21) is too long: 257 lines 🚨
- src/rules/vue-essential/vforNoKey.test.ts:
  rrd ~ Long <script> blocks: (111 lines) 🚨
- src/rules/rrd/nestedTernary.test.ts:
  rrd ~ Long <script> blocks: (121 lines) 🚨
- src/helpers/extractPropNames.ts:
  rrd ~ amount of comments: The script block contains 59.44% comments, which exceeds the limit of 30%. 🚨
- src/rules/rrd/amountOfComments.test.ts:
  rrd ~ Long <script> blocks: (127 lines) 🚨
  rrd ~ short variable names: variable: (x) 🚨
  rrd ~ short variable names: variable: (y) 🚨
  rrd ~ short variable names: variable: (z) 🚨
  rrd ~ short variable names: variable: (x) 🚨
  rrd ~ short variable names: variable: (y) 🚨
  rrd ~ short variable names: variable: (z) 🚨
  rrd ~ short variable names: variable: (x) 🚨
  rrd ~ short variable names: variable: (y) 🚨
- src/rules/rrd/noSkippedTests.test.ts:
  rrd ~ magic numbers: magic numbers found (line #41 magic number: 2) 🚨
  rrd ~ no skipped tests: line #27 skip test found: ".todo" 🚨
  rrd ~ no skipped tests: line #41 skip test found: ".todo" 🚨
  rrd ~ no skipped tests: line #49 skip test found: ".skip" 🚨
  rrd ~ no skipped tests: line #53 skip test found: ".skipIf" 🚨
  rrd ~ no skipped tests: line #67 skip test found: ".skip" 🚨
  rrd ~ no skipped tests: line #72 skip test found: ".skipIf" 🚨
- src/rules/rrd/amountOfComments.ts:
  rrd ~ function size: function (resetResults#7) is too long: 50 lines 🚨
  rrd ~ Zero Length Comparison: line #40 zero length comparison found (results) 🚨
- src/rules/rrd/noSkippedTests.ts:
  rrd ~ function size: function (resetResults#8) is too long: 43 lines 🚨
  rrd ~ Zero Length Comparison: line #34 zero length comparison found (results) 🚨
- src/rules/security/rateLimiter.ts:
  rrd ~ function size: function (resetResults#6) is too long: 39 lines 🚨
  rrd ~ Zero Length Comparison: line #28 zero length comparison found (results) 🚨
- src/helpers/getEscapedLink.ts:
  rrd ~ amount of comments: The script block contains 74.45% comments, which exceeds the limit of 30%. 🚨
- src/types/Override.ts:
  rrd ~ amount of comments: The script block contains 31.82% comments, which exceeds the limit of 30%. 🚨
- src/helpers/getConfig.ts:
  rrd ~ else conditions: else clauses found (1) 🚨

🔍 Download Full Analysis Details

For any issues or feedback, feel free to report them here.

Copy link

pkg-pr-new bot commented Oct 7, 2024

Open in Stackblitz

yarn add https://pkg.pr.new/rrd108/[email protected]

commit: f7eaebc

Copy link
Collaborator

@David-Pena David-Pena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@rrd108 rrd108 merged commit a6a000e into main Oct 7, 2024
31 checks passed
@rrd108 rrd108 deleted the 337-add-new-rule-rrd-expressioninvfor branch October 8, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new rule (rrd) expressionInVfor
2 participants