-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configurable launcher #14
Comments
@rprichard, do you have an idea how to explicitly launch the distros in either the current directory or the home directory, without having to tweak the WSL default distro? See the discussion starting from microsoft/WSL#2348 (comment). |
I started on a e.g.:
|
Should wslbridge search the PATH for the given program, e.g so that I wasn't sure it made sense to allocate
|
I agree with your hidden statement that this is all very chaotic and undocumented. To find the launcher, I guess it's sufficient to look in %LOCALAPPDATA%\Microsoft\WindowsApps (that's also included in the PATH). However, what that means for other users, given that the "app" itself is installed in %PROGRAMFILES%\WindowsApps, I do not know. Maybe you can look up there as well (although the folder is not readable for normal users). About parameter handling, our main issue is the question how to set the start directory. I would happily leave all other questions of parameter usage to users who want to launch WSL apps directly. |
Please check microsoft/WSL#2348 (comment); |
Maybe I should add a I need to study what that escaping is. I wonder if the differences were intentional, or will the next WSL distro cause problems again? An alternative is to have the wslbridge frontend thoroughly escape shell control characters (spaces, quotes, slashes, etc) and make little-to-no assumptions about how |
I've just tried So a possible wslbridge option (short preferred) could be like I do not see what problem with escaping there is, it doesn't seem to be important for wsltty. |
However, bash accepts a |
I pushed a commit to the wsl-launcher branch that replaces I think I'm open to having wslbridge scan Conceivably, there could be single The current GUID parsing is flexible -- see the I wonder if two distributions can have the same name (but different GUIDs). |
It looks like |
@mintty Oh, I didn't see your comments before I posted. Maybe the fix is much simpler, then. wslbridge continues using |
Ok, I pushed the simpler |
Thanks a lot. Just uploaded wsltty updates to support the new WSL distribution model. |
Thank you again. I made a release meanwhile, referring to |
The |
Great, thanks! |
With MS-Store-based WSL, the launcher is not bash.exe anymore.
It would be useful to add an option to set the desired launcher, e.g. (e.g.
-l %LOCALAPPDATA%/Microsoft/WindowsApps/ubuntu.exe
).Another open issue is to find out which incarnations of WSL exist on the system (apparently now multiple installations can coexist, and other distributions than Ubuntu are under preparation).
See wsltty/issues#52.
The text was updated successfully, but these errors were encountered: