-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Heroku-22 stack #55
Comments
hmm this is tricky. I don't think that's something we can resolve in this repository - this gem simply ships the binary from https://github.com/wkhtmltopdf/wkhtmltopdf , unfortunately that repo is in a semi-abandoned state. We could try to compile a binary from source with openssl 3 but it still might not work due to the breaking changes mentioned in the article 🤔 |
Looks like someone has already compiled a binary for Ubuntu 22: wkhtmltopdf/packaging#114 testing that shortly. |
Hi - I think it actually works - here's a test page: https://wkhtmltopdf-demo.herokuapp.com/greetings/hello.pdf could you test this on your end also? here's my test "app": could you try it with: https://github.com/pallymore/wkhtmltopdf-test/blob/main/Gemfile#L29 gem 'wkhtmltopdf-heroku', git: 'https://github.com/rposborne/wkhtmltopdf-heroku.git', branch: '2.12.6.0-jammy' |
@pallymore there's an official release for 22.04 published just now. |
thanks - checking if those binaries work 🤔 |
Hi @ashkulz - the latest release does not work on Heroku-22. @guillaumewrobel please let me know if that branch works for you: gem 'wkhtmltopdf-heroku', git: 'https://github.com/rposborne/wkhtmltopdf-heroku.git', branch: '2.12.6.0-jammy' |
@pallymore yeah, there were some issues and I've deleted the release. |
@pallymore the |
awesome, for now i've published the branch as version https://rubygems.org/gems/wkhtmltopdf-heroku/versions/2.12.6.0.pre.jammy |
@pallymore please check again with the latest build. |
Hi @ashkulz the latest release works! thank you! |
Released: https://rubygems.org/gems/wkhtmltopdf-heroku/versions/2.12.6.1.pre.jammy Thanks! Is there going to be a Ubuntu 20 (Focal) AMD64 build? |
@pallymore there is already a Ubuntu 20.04 build which was part of the original 0.12.6 release ... not sure what you mean? 🤔 |
nvm, I thought this release is for thank you again. |
Yeah, the only changes in the |
Hi there, not sure if anyone will see this but I just upgraded my heroku to 22 stack and tried to add the experimental gem to my gemfile and redeploy but I am still getting the same error. I might be missing something can anyone help? gem 'wicked_pdf' |
@toddsutt I see you are using both I'd recommend keeping |
@pallymore thank you for the response! As you can see, I don't understand what these gems are doing, so I will give that a try! |
@pallymore after your suggestion I get this error on heroku: Command Error: /app/vendor/bundle/ruby/3.1.0/gems/bundler-2.3.10/lib/bundler/rubygems_integration.rb:319:in `block in replace_bin_path': can't find executable wkhtmltopdf for gem wkhtmltopdf-binary. wkhtmltopdf-binary is not currently included in the bundle, perhaps you meant to add it to your Gemfile? (Gem::Exception) |
yea looks like it's still trying to find |
@pallymore again, thank you so much for helping me I really appreciate it. Here is the relevant part of my gemfile:
wicked_pdf.rb is completely default:
|
Do I need to do something to uninstall the binary gem from heroku after moving it to development? Like delete my Gemfile.lock? |
Sorry for the late response - in regards to the lock file, yea you will need to run I'd search |
also could you DM me on twitter we can continue there if you are still having issues: https://twitter.com/Yuruiology 👋🏻 |
@pallymore I finally figured it out! Btw I couldn't message you on twitter it said I was unable to send messages even after following. I tried a whole lot of things but it ended up just being that I needed to add |
great - I don't think however I think I know the problem now - in your config you had: WickedPdf.config = {
} which overrides the whole WickedPdf.config ||= {}
WickedPdf.config.merge!({
# your extra configurations here
}) this should eliminate the needs of having to set an |
What is the solution I have the same problem |
@nickyczeme for me it was what @pallymore last said - I simply needed to remove the WickedPdf.config = {} from my initializer |
Heroku-22 Stack has been released and it breaks the wkhtmltopdf-heroku gem with the following error message:
Heroku explains this with:
@pallymore tell me if I can help by suggesting a PR 🙏
The text was updated successfully, but these errors were encountered: