tus-sender: resolveUploadUrl does not work properly when using relative path

[TheMadKow]

Describe the bug
While using relative path, first connection with server succeeds, and then fails.

When using url : '/relative-path/files' the client will fail due to the following error

tusSender.create: create upload failed TypeError: Failed to construct 'URL': Invalid URL
at resolveUploadUrl (createUpload.js:12)
at handleSuccessfulCreateResponse (createUpload.js:24)
at createUpload.js:79

following code lines:

    //absolute location, concatenate to upload URL without any other path
    uploadUrl = new URL(createUrl).origin.replace(/\/$/, "") + location;

because createUrl variable is relative, and URL function throws an error.

To Reproduce
It's in my code base, maybe the same as issue #242 but with relative path instead of absolute path.
That is -- Use it as a destination: "/files"

Expected behavior
To be able to provide relative path to the server.

Versions
After release 0.13.5 on Chrome/Edge Chromium.

Code

** Doesn't Work with relative URL **

        <TusUploady
            destination={{
                url: '/Core/HandleTusFiles',
....

</TusUploady>

** Works with absolute URL **

        <TusUploady
            destination={{
                url: 'https://localhost:44315/Core/HandleTusFiles',
....

</TusUploady>

[yoavniran]

thanks @TheMadKow its very clear now what the issue is.
I will issue a fix for this very soon

[TheMadKow]

Thanks @yoavniran :)
Do let me know if more information is needed ^^

[yoavniran]

@TheMadKow Just making sure, since you provide a destination without the origin and you want to return an absolute path from your TUS server. This means that the final upload URL will be just the absolute path.

Example:

If: Destination URL == /Core/HandleTusFiles
and: Location header == /files

Upload URL will be: /files

This is your expectation, correct?

[TheMadKow]

@yoavniran - the issue is the exception thrown by the code after initial handshake is establised.

If: Destination URL == /Core/HandleTusFiles
and: Location header == https://localhost:44315/Core/HandleTusFiles

Upload URL will be: https://localhost:44315/Core/HandleTusFiles/[guid]

---

Currently, the destination URL is relative (/Core/HandleTusFiles), and Location header returns a correct absolute path (location: /Core/HandleTusFiles/dade9da9f5f141b7aa4a8f49cd18ba6b), but afterwards it fails.

That is, the first post request works just fine, and returns correct location with status code 201.
The following requests fails due to the following error

tusSender.create: create upload failed TypeError: Failed to construct 'URL': Invalid URL
    at resolveUploadUrl (createUpload.js:12)
    at handleSuccessfulCreateResponse (createUpload.js:24)
    at createUpload.js:79

Specifically, I think the URL function tries to work with the relative path, and not the provided location from the server.

If that's not possible, maybe it's easier to specify that the destination URL should always be absolute.
Because when I do write the absolute path, it works just fine :)

Best,
Eliran :)

[yoavniran]

The problem is clear and I have a fix for it - #247
I just wanted to make sure the fix is what you need. I believe it is. I will merge later on today and release a new version

[TheMadKow]

Thank you ! :)

[yoavniran]

0.13.6 is now out. Please check that it does solve the problem.
thanks!

[TheMadKow]

Yes, I can confirm it works fine now.
Thank you for the quick fix !