-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safari: Zoomable images make the body extend beyond the content #627
Comments
Thanks for the bug report! I'll need to look into why it's doing that when I get some time. |
Thank you very much, I really appreciate it! |
You're right, and this is super weird (and bad). The "ghost" box that the button—for accessibility—gets put in should be the exact size of the image. I think I'll have time tomorrow to figure this out. I'll try to reproduce this with that same image somewhere else and start from there. If I can reproduce it in isolation, I can fix it. |
Update: I know what the problem is, and I have what I believe is a pretty good fix, but I need to test it quite a bit. Once I do that, I'll release a beta version, get you to test it, and then we can make it live. |
@imalfect Can you please install |
Hey @rpearce, I just installed it and tested whether the issue is resolved. It seems like the empty space at the end of the website doesn't exist anymore. Thank you very much for spending your time on looking into this issue, I really appreciate your work! Closing the issue as it is resolved. |
@imalfect Thanks! I'll put together an official release later today for |
@imalfect This fix has been officially published in |
Thank you! I really appreciate it! You too! |
Description
When using react-medium-image-zoom for my images, a long blank space after the website's content apperars (below the footer), I diagnosed it is happening because of this module, specifically
because of the styles of the expand.
height: 390px; left: 572px; width: 656px; top: 2994px;
This issue is exclusive to safari (I guess safari really is the internet explorer of web development nowadays lol), does not happen on other browsers.
You can view an example here: https://kasmedia.com/article/kaspa-market-dashboard-2024-06-26-kaspa-on-chain-metrics-showing-signs-of-bullish-reversal
You can check another page that does not contained images with this package, and notice the issue does not happen there: https://kasmedia.com/article/the-silver-standard-rusty-kaspa-s-evolution-to-digital-excellence
I'm pretty sure it's just safari's problem, but if there's any solution to this problem that you're aware of, I'd be extremely grateful if you could share it.
Cheers.
The text was updated successfully, but these errors were encountered: