Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for customising build.sub_commands directly from distutils has been deprecated and is about to be removed from setuptools #19

Open
abravalheri opened this issue Apr 22, 2024 · 3 comments

Comments

@abravalheri
Copy link

The following feature in setuptools has been deprecated for almost 2 years and is about to be removed:

https://github.com/pypa/setuptools/blob/1ed759173983656734c3606e9c97a348895e5e0c/setuptools/command/build.py#L13-L27

It might be a good idea to import build directly from setuptools for the following code:

build.build.sub_commands.append(('build_msdeploy', has_msdeploy_manifest))

(maybe other places)
(build is available directly from setuptools, starting on version v62.4.0)

@rpatterson
Copy link
Owner

It might be a good idea to import build directly from setuptools for the following code:

Thanks for the detailed report and thanks especially for including a potential fix, @abravalheri!

This project has been inactive for over a decade. AFAIK, I was the only user ever. I'm not likely to fix this or any other issues. Are you or anyone you know using it? If yes, do you know anyone who wants to take over maintenance? If no, how did you find this project in order to report this issue? Are you a bot? ;-)

@abravalheri
Copy link
Author

abravalheri commented Apr 23, 2024

Hi @rpatterson. Thanks for the response. I am not using the project. I am working on the updates for setuptools, and I used Github search to try to find codebases that would potentially be broken after the removal.

Please feel free too close the issue if you think is not relevant.

@rpatterson
Copy link
Owner

rpatterson commented Apr 23, 2024

Please feel free too close the issue if you think is not relevant.

Oh, it's relevant. This will remain open as a scarlet letter of not being maintained. ;-)

But seriously, thanks much for your work on behalf of a whole community of developer-users. I value the diligence, @abravalheri.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants