Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring monolithic legacy code #1

Open
3 tasks done
cprima opened this issue Oct 15, 2024 · 5 comments · Fixed by #2
Open
3 tasks done

Refactoring monolithic legacy code #1

cprima opened this issue Oct 15, 2024 · 5 comments · Fixed by #2
Assignees
@cprima
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone
codebase UiPath C...

Comments

@cprima
Copy link
Contributor

cprima commented Oct 15, 2024 •
edited
Loading

Requirements

  • Define learning objectives
  • Write Code as baseline
  • come up with 2-person Git flow to simulate a code review with Workflow Analyzer
@cprima cprima self-assigned this Oct 15, 2024
@cprima cprima converted this from a draft issue Oct 15, 2024
@cprima cprima linked a pull request Oct 29, 2024 that will close this issue
[PR] Initial code from dev-cpm #2
Merged
@cprima
Copy link
Contributor Author

cprima commented Nov 1, 2024

Regarding

[x] come up with 2-person Git flow to simulate a code review with Workflow Analyzer

The Git Repository Snapshot Archiver creates a collection of repository snapshots, for unzipping on the reviewer's system and conflict-free UiPath Studio demonstration. Prevents the necessity to switch branches which UiPath Studio does not seamlessly support.

@cprima cprima moved this from Todo to In progress in rpapub 2024-25 Nov 1, 2024
@cprima cprima added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 1, 2024
@cprima
Copy link
Contributor Author

cprima commented Nov 1, 2024 •
edited
Loading

When to refactor

  • bug report
  • change request
  • dedicated (budgeted) effort
    • EOL / EOS
    • …
  • developer onboarding
  • …

@cprima
Copy link
Contributor Author

cprima commented Nov 1, 2024 •
edited
Loading

Obstacles

  • Bei einem change request: Unklarheit über Vorgehen und Prioritäten. Gefahr der Verschlimmbesserung
  • Rechtfertigung Aufwand: Ohne geteiltes Verständnis der Vorgehensweise entstehen
  • Zu viel auf einmal
  • Nicht wissen, was zu tun ist
  • …

@cprima
Copy link
Contributor Author

cprima commented Nov 9, 2024

To be

Modularize units, especially later in the process
Have interface to mail message
Pass by reference beachten
Refactor from click path to e.g. input processing output
From loop to transactions, batch size

@cprima
Copy link
Contributor Author

cprima commented Nov 12, 2024

Metrics

  • Workflow Analyzer
  • arguments

This was referenced Nov 12, 2024
Closed
Open
Closed
Open
Closed
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cprima cprima

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
rpapub 2024-25
Status: In progress
Milestone
codebase UiPath Chapter Event Refacto...
Development

Successfully merging a pull request may close this issue.

[PR] Initial code from dev-cpm rpapub/PurposefulPromethium
1 participant
@cprima