Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A page without URLs displays an infinite spinner #13

Open
lele-blue opened this issue Jul 13, 2021 · 1 comment
Open

A page without URLs displays an infinite spinner #13

lele-blue opened this issue Jul 13, 2021 · 1 comment

Comments

@lele-blue
Copy link

If spank has no urls (empty array in urlIndex.json), it just displays an infinite spinner without an error message.
I think it might be better to display an error message in this case.

@jakobrosenberg
Copy link
Member

Sorry about the slow reply @Ertego .

I much agree. I'll add it to our todo list... unless you're interested in submitting a PR. 😇

const assert from 'assert'

const getConfig = async input => {    
    const options = configent(defaults, input, {useDetectDefaults: true, module})
    /** run assertions */
    return options
}

https://github.com/roxiness/spank/blob/master/getConfig.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants