Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"with attachment" filter fails on some fts engines #9514

Closed
2 tasks done
exi opened this issue Jun 23, 2024 · 4 comments
Closed
2 tasks done

"with attachment" filter fails on some fts engines #9514

exi opened this issue Jun 23, 2024 · 4 comments
Milestone

Comments

@exi
Copy link

exi commented Jun 23, 2024

Prerequisites

  • I have searched for duplicate or closed issues
  • I can recreate the issue with all plugins disabled

Describe the issue

The standard email filter with attachment uses an imap filter for header content-type with value multipart/m, which assumes that whatever search engine is used does an implicit wildcard search for multipart/m*, which is not always the case, for example with fts_xapian in dovecot.

The IANA mime type list only lists one sensible multi part type which matches this and that's multipart/mixed.

Could we change the roundcube filter to match exactly multipart/mixed here to allow for wider fts engine support?

What browser(s) are you seeing the problem on?

Chrome, Edge, Firefox, Safari

What version of PHP are you using?

V8.2

What version of Roundcube are you using?

V1.7

JavaScript errors

No response

PHP errors

No response

@alecpl
Copy link
Member

alecpl commented Jun 23, 2024

I guess we can change that.

In git-master we use 'application/', 'multipart/m', 'multipart/signed', 'multipart/report'. Is 'application/' not an issue?

@exi
Copy link
Author

exi commented Jun 23, 2024

@alecpl

Is 'application/' not an issue?

I have no idea, i just noticed that my attachments with multipart/mixed don't show up. I have not tested/checked application/ yet but I would think that within an email, if there is any text at all, it will always be multipart/*.

@exi
Copy link
Author

exi commented Jun 28, 2024

@alecpl Would you like me to send a pullrequest with the changes i already applied locally, or do you just change it yourself?

@alecpl
Copy link
Member

alecpl commented Jul 21, 2024

Fixed.

@alecpl alecpl closed this as completed Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants