Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

privatize semgent's functions #22

Closed
amityahav opened this issue Aug 10, 2023 · 1 comment
Closed

privatize semgent's functions #22

amityahav opened this issue Aug 10, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@amityahav
Copy link
Contributor

This is just my OCD kicks in, there is no actual access to the semgent's functions from the WAL struct since segment attr is private itself, but should its functions be private as well?
@roseduan
Copy link
Contributor

Yes, some Segment functions should be private, you can list them here(I can recheck it) and then create a PR.

Thanks.

@roseduan roseduan added the enhancement New feature or request label Aug 11, 2023
@amityahav amityahav mentioned this issue Sep 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roseduan @amityahav