Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: may be problem, some highlight changed in "dawn" variant #206

Closed
nanozuki opened this issue Jan 8, 2024 · 2 comments
Closed

bug: may be problem, some highlight changed in "dawn" variant #206

nanozuki opened this issue Jan 8, 2024 · 2 comments
Labels

Comments

@nanozuki
Copy link
Contributor

nanozuki commented Jan 8, 2024

Neovim version (nvim -v)

NVIM v0.9.5 Build type: Release LuaJIT 2.1.1693350652

Terminal / multiplexer

kitty

Describe the bug

  1. The seprator's background between windows seems wrong, not same with windows' background:
    图片
  2. Color changed in NeoTree. Became more black and gray. Is this expective change or bug?
    图片
    图片

Repro

vim.o.packpath = "/tmp/nvim/site"

local plugins = {
	rose_pine = "https://github.com/rose-pine/neovim",
	-- ADD OTHER PLUGINS _NECESSARY_ TO REPRODUCE THE ISSUE
}

for name, url in pairs(plugins) do
	local install_path = "/tmp/nvim/site/pack/test/start/" .. name
	if vim.fn.isdirectory(install_path) == 0 then
		vim.fn.system({ "git", "clone", "--depth=1", url, install_path })
	end
end

require("rose-pine").setup({
	require("rose-pine").setup({ variant = "dawn" }),
})

vim.cmd("colorscheme rose-pine")
@mvllow
Copy link
Member

mvllow commented Jan 8, 2024

  1. Fixed window separator in fix: mismatched WinSeparator background #208.
  2. Reverted palette changes in revert: improve palette contrast #207. We are experimenting with higher contrast for a few colours but will continue testing on the canary branch instead. Would love feedback on if you like or don't like the darker text in dawn, though.

Thanks for reporting :)

@mvllow mvllow closed this as completed Jan 8, 2024
@nanozuki
Copy link
Contributor Author

nanozuki commented Jan 9, 2024

Thank you for your work.

Regarding the color palette change, I'm very used to the warm and colorful feel of the previous dawn variant. Since this update has many changes, I doubt it's a bug.

But I also think making different attempts, such as increasing contrast, is necessary and beneficial for this project, so please continue. Maybe add a option to alter the contrast is also a way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants