Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting parameters atomically using ros2 service command line #721

Open
deepanshubansal01 opened this issue Jun 9, 2022 · 2 comments · May be fixed by #727
Open

Support setting parameters atomically using ros2 service command line #721

deepanshubansal01 opened this issue Jun 9, 2022 · 2 comments · May be fixed by #727
Assignees
@ihasdapie
Labels
enhancement New feature or request

Comments

@deepanshubansal01
Copy link
Contributor

deepanshubansal01 commented Jun 9, 2022 •
edited
Loading

Feature request

It would be nice to support setting params atomically using ros2 service call command line.

Feature description

Currently, the ros2 service call sets parameters in a non atomic fashion, meaning if one fails it wouldn't affect the other params being set. It would good to support an optional argument --atomically or something which could help in debugging and testing if params are required to be set in an atomic fashion using the command line.

Implementation considerations

For setting the params atomically using ros2 service call we could leverage the already existing Node API service rcl_interfaces::srv::SetParametersAtomically.
@adityapande-1995 adityapande-1995 added the enhancement New feature or request label Jun 9, 2022
@alsora
Copy link
Contributor

alsora commented Jun 10, 2022

Hi @deepanshubansal01 I think that this issue would be better suited for the https://github.com/ros2/ros2cli repository.
That's where the code that implements ros2 service call or similar CLI commands live.

P.S. note that you can set parameters with ros2 param set

@clalancette
Copy link
Contributor

Hi @deepanshubansal01 I think that this issue would be better suited for the https://github.com/ros2/ros2cli repository.
That's where the code that implements ros2 service call or similar CLI commands live.

Agreed. The underlying rclcpp and rclpy client libraries already has this functionality, we would just need to somehow expose it via the command-line. I'm going to move this over to ros2cli.

@clalancette clalancette transferred this issue from ros2/rclcpp Jun 10, 2022
@ihasdapie ihasdapie linked a pull request Jun 23, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ihasdapie ihasdapie

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support setting parameters atomically ros2/ros2cli
5 participants
@clalancette @adityapande-1995 @alsora @deepanshubansal01 @ihasdapie