Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multiple definition if message with same name as service exists #272

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

dirk-thomas
Copy link
Member

Fixes the problem reported in https://answers.ros.org/question/354302/ros1_bridge-build-error-for-turtlebot3/

CI build just to check for regressions: Build Status

@dirk-thomas dirk-thomas added the bug Something isn't working label Jun 8, 2020
@dirk-thomas dirk-thomas self-assigned this Jun 8, 2020
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
It's hard to actually know if it works, as there's no regression test for this case.

@dirk-thomas dirk-thomas merged commit aaf4ccf into master Jun 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/fix-multiple-definition branch June 8, 2020 21:07
@dirk-thomas
Copy link
Member Author

Fast-forwarded the foxy branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants