fix removing obsolete ROS 2 service bridges #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dirk Thomas <[email protected]>
dirk-thomas
commented
May 22, 2020
|
|
||
| // TODO(wjwwood): fix bug where just a ros2 client will cause a ros1 service to be made |
There was a problem hiding this comment.
The patch also fixes this issue.
jacobperron
approved these changes
May 22, 2020
There was a problem hiding this comment.
LGTM pending CI
I agree it would be great is the original reporter (@audrow) could confirm if this fixes the issue.
Signed-off-by: Dirk Thomas <[email protected]>
wjwwood
approved these changes
May 22, 2020
delete-merged-branch
bot
deleted the
dirk-thomas/fix-removing-service-bridges
branch
hsd-dev
pushed a commit
to hsd-dev/ros1_bridge
that referenced
this pull request
Nov 17, 2020
* fix removing obsolete ROS 2 service bridges Signed-off-by: Dirk Thomas <[email protected]> * include utility Signed-off-by: Dirk Thomas <[email protected]> Signed-off-by: Harsh Deshpande <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #265. Requires ros2/rclcpp#1131.
CI builds testing
rclcppwith only FastRTPS:Packaging build with only FastRTPS: