Fix parameter bridge for topic if ros1 and ros2 type have a different name #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fferent type name) Signed-off-by: Cyrille Berger <[email protected]>
cyrilleberger
force-pushed
the
fix-different-msg-name
branch
from
4132759 to
67898df
Compare
|
The message printed above provides misleading information now. Please update that accordingly. |
dirk-thomas
added
in progress
|
Do you mean the commit message? |
|
Sorry, I though I commented on a specific line. Without that context its not obvious. I was referring to the message printed a few lines above the change: line 69-72. |
…type Signed-off-by: Cyrille Berger <[email protected]>
|
Is there anything else I need to change? |
dirk-thomas
added
in review
Please comment after pushing additional commits to your PRs. Otherwise nobody gets a notification and it is unlikely someone will review the changes. The change looks good to me. Thanks for the improvement. |
|
It seems like your fork is outdated which failed the CI build. Testing a rebased version of your fork - the result looks good: |
dhananjaysathe
pushed a commit
to rapyuta-robotics/ros1_bridge
that referenced
this pull request
Aug 22, 2019
… name (ros2#177) * don't specify ros1 type (it fixes the bridge if ros1 and ros2 have different type name) Signed-off-by: Cyrille Berger <[email protected]> * remove ROS1 type from messages, since that type is guessed from ROS2 type Signed-off-by: Cyrille Berger <[email protected]> Signed-off-by: Dhananjay Sathe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have set ros1 type to "" since in create_bidirectional_bridge it can find out which type to use for ros1 when only specifying ros2 type.
An alternative fix would be to allow to specify different type for ros1 and ros2 in the parameters.