ensure that the diagnostic_msgs package is from ROS 2 #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
added
enhancement
wjwwood
approved these changes
Feb 22, 2019
dhananjaysathe
pushed a commit
to rapyuta-robotics/ros1_bridge
that referenced
this pull request
Aug 22, 2019
* ensure that the diagnostic_msgs package is from ROS 2 * remove CMAKE_PREFIX_PATH from error message Signed-off-by: Dhananjay Sathe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #168.
This patch improves the error behavior is the ROS 2 package
diagnostic_msgsisn't available. Without the patchdiagnostic_msgsis found from ROS 1 (since in ROS 2 it wasn't available) and the build fails with missing headers / symbols.