Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake configure step should list all ROS2 message packages found #116

Closed
mikaelarguedas opened this issue Apr 17, 2018 · 0 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@mikaelarguedas
Copy link
Member

Currently it prints only the output of find_package so if dependencies are found during the process they are not listed.

We should instead find_package the ROS 2 packages with QUIET and then print the full list of packages found.

From nightlies:

-- Found composition: 0.4.0 (/home/rosbuild/ci_scripts/ws/install/share/composition/cmake)
-- Found stereo_msgs: 0.4.0 (/home/rosbuild/ci_scripts/ws/install/share/stereo_msgs/cmake)
-- Found lifecycle_msgs: 0.4.0 (/home/rosbuild/ci_scripts/ws/install/share/lifecycle_msgs/cmake)
-- Found visualization_msgs: 0.4.0 (/home/rosbuild/ci_scripts/ws/install/share/visualization_msgs/cmake)
-- Found example_interfaces: 0.4.0 (/home/rosbuild/ci_scripts/ws/install/share/example_interfaces/cmake)
-- Found actionlib_msgs: 0.4.0 (/home/rosbuild/ci_scripts/ws/install/share/actionlib_msgs/cmake)
-- Found rosgraph_msgs: 0.4.0 (/home/rosbuild/ci_scripts/ws/install/share/rosgraph_msgs/cmake)
-- Found std_srvs: 0.4.0 (/home/rosbuild/ci_scripts/ws/install/share/std_srvs/cmake)
-- Found trajectory_msgs: 0.4.0 (/home/rosbuild/ci_scripts/ws/install/share/trajectory_msgs/cmake)
-- Found shape_msgs: 0.4.0 (/home/rosbuild/ci_scripts/ws/install/share/shape_msgs/cmake)
-- Found logging_demo: 0.4.0 (/home/rosbuild/ci_scripts/ws/install/share/logging_demo/cmake)
-- Found pendulum_msgs: 0.4.0 (/home/rosbuild/ci_scripts/ws/install/share/pendulum_msgs/cmake)
-- Found nav_msgs: 0.4.0 (/home/rosbuild/ci_scripts/ws/install/share/nav_msgs/cmake)
-- Found tf2_msgs: 0.8.0 (/home/rosbuild/ci_scripts/ws/install/share/tf2_msgs/cmake)
-- Found test_msgs: 0.4.0 (/home/rosbuild/ci_scripts/ws/install/share/test_msgs/cmake)

As an example: sensor_msgs is not in the list

But we actually build factories for it:

composition_factories.cpp.o
stereo_msgs_factories.cpp.o
lifecycle_msgs_factories.cpp.o
visualization_msgs_factories.cpp.o
example_interfaces_factories.cpp.o
rcl_interfaces_factories.cpp.o
std_msgs_factories.cpp.o
actionlib_msgs_factories.cpp.o
rosgraph_msgs_factories.cpp.o
std_srvs_factories.cpp.o
trajectory_msgs_factories.cpp.o
shape_msgs_factories.cpp.o
geometry_msgs_factories.cpp.o
diagnostic_msgs_factories.cpp.o
logging_demo_factories.cpp.o
pendulum_msgs_factories.cpp.o
nav_msgs_factories.cpp.o
tf2_msgs_factories.cpp.o
sensor_msgs_factories.cpp.o
test_msgs_factories.cpp.o
@mikaelarguedas mikaelarguedas added the enhancement New feature or request label Apr 17, 2018
@dirk-thomas dirk-thomas self-assigned this Jun 18, 2018
@dirk-thomas dirk-thomas added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Jun 18, 2018
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants