subscriptions, services and clients pointer arguments are not checked for NULL

[dejanpan]

Bug report

Required Info:

• Operating System:

  • all

• Installation type:

  • source

• Version or commit hash:

• rmw_connext/rmw_connext_shared_cpp/include/rmw_connext_shared_cpp/wait.hpp

  Line 124 in 661993a

  for (size_t i = 0; i < subscriptions->subscriber_count; ++i) {

• rmw_connext/rmw_connext_shared_cpp/include/rmw_connext_shared_cpp/wait.hpp

  Line 161 in 661993a

  for (size_t i = 0; i < services->service_count; ++i) {

• rmw_connext/rmw_connext_shared_cpp/include/rmw_connext_shared_cpp/wait.hpp

  Line 183 in 661993a

  for (size_t i = 0; i < clients->client_count; ++i) {

• DDS implementation:

  • rmw_connext
  • rmw_fastrtps
  • rmw_opensplice

Steps to reproduce issue

I did not write a test case but I can if needed

Expected behavior

NA

Actual behavior

NA

Additional information

I will provide a PR.

Solution should be like this:

  // add a condition for each subscriber
  if (subscriptions) {
    for (size_t i = 0; i < subscriptions->subscriber_count; ++i) {
      OpenSpliceStaticSubscriberInfo *subscriber_info =
        static_cast<OpenSpliceStaticSubscriberInfo *>(subscriptions->subscribers[i]);
      if (!subscriber_info) {
        RMW_SET_ERROR_MSG("subscriber info handle is null");
        return RMW_RET_ERROR;
      }
      DDS::ReadCondition *read_condition = subscriber_info->read_condition;
      if (!read_condition) {
        RMW_SET_ERROR_MSG("read condition handle is null");
        return RMW_RET_ERROR;
      }
      rmw_ret_t status = check_attach_condition_error(
        dds_waitset->attach_condition(read_condition));
      if (status != RMW_RET_OK) {
        return status;
      }
    }
  }

@serge-nikulin fyi