Avoid generating the exception when rcl_send_response times out. #1136
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fujitatomoya
commented
Jun 29, 2023
There was a problem hiding this comment.
@kghost that would be really appreciated if you can have a look!
CC: @clalancette @audrow
sloretz
previously approved these changes
Jul 5, 2023
|
CI:
|
clalancette
reviewed
Jul 6, 2023
agoeckner
reviewed
Jul 6, 2023
fujitatomoya
force-pushed
the
fujitatomoya/20230629-avoid-exception-responce
branch
from
da0947e to
3f8a912
Compare
|
rebased on rolling has been done too. |
|
CI:
|
|
CI:
windows failure is unrelated. |
|
@clalancette @sloretz could you do another review? |
clalancette
approved these changes
Jul 20, 2023
Signed-off-by: Tomoya Fujita <[email protected]>
Signed-off-by: Tomoya Fujita <[email protected]>
fujitatomoya
force-pushed
the
fujitatomoya/20230629-avoid-exception-responce
branch
from
3f8a912 to
3e32309
Compare
|
CI:
|
delete-merged-branch
bot
deleted the
fujitatomoya/20230629-avoid-exception-responce
branch
|
@Mergifyio backport iron humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 18, 2023
Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 6cab7e3)
mergify bot
pushed a commit
that referenced
this pull request
Aug 18, 2023
Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 6cab7e3)
fujitatomoya
added a commit
that referenced
this pull request
Sep 1, 2023
…) (#1151) Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 6cab7e3) Co-authored-by: Tomoya Fujita <[email protected]>
fujitatomoya
added a commit
that referenced
this pull request
Sep 1, 2023
…) (#1152) Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 6cab7e3) Co-authored-by: Tomoya Fujita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of ros2/ros2#1253
counterpart of ros2/rclcpp#2215
depends on ros2/rcl#1048