Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flakiness in TestTimersManager unit-test #2468

Merged
merged 2 commits into from
Mar 28, 2024
Merged

fix flakiness in TestTimersManager unit-test #2468

merged 2 commits into from
Mar 28, 2024

Commits on Mar 27, 2024

  1. fix flakiness in TestTimersManager check_one_timer_cancel_doesnt_affe… 

    …ct_other_timers

the previous version of the test was relying on the assumption that a timer with 1ms period gets called at least 6 times if the main thread waits 15ms. this is true most of the times, but it's not guaranteed, especially when running the test on windows CI servers. the new version of the test makes no assumptions on how much time it takes for the timers manager to invoke the timers, but rather focuses on ensuring that they are called the right amount of times, which is what's important for the purpose of the test

Signed-off-by: Alberto Soragna <[email protected]>
    @alsora
    alsora committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    f2869e0 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. add 30 seconds timeout to each while loop 

    Signed-off-by: Alberto Soragna <[email protected]>
    @alsora
    alsora committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    e06bd91 View commit details
    Browse the repository at this point in the history