-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix python-attrs-pip
for Ubuntu
#36888
Conversation
Replace Ubuntu in the `python-attrs-pip` key, removed in commit 59517bc.
b29814c
to
d00bb77
Compare
CI broke on the first hunk of the original PR; that's now backed out, and the PR description updated. I'm still not sure if the
|
Hmmm. I think that the status quo is incorrect or at least odd. And opened #36893 to address that in a minimally compatible way. @tfoote was the intent in removing the pip definition for just Ubuntu made under the assumption that the pip key was also only there to backfill for Trusty? If that's the case I think we could consider removing it for Debian as well. @zultron what platforms are you on that you're relying on this key? All ROS platforms which support python2 are nearing the end of their support, so the best thing to do if you intend to keep using them may be to switch to a fixed copy of the rosdep database. |
The fix in #36893 looks like the right fix. The pip rule was used before the debian packages were available. And the debian rule could be extended to support older platforms. But I think that now all the older platforms are eol. So I removed the pip rule because all the expected platforms are now unsupported. So I think that we should keep the pip rule removed. |
Since there hasn't been a response here, I'm going to close this as fixed by #36893 |
Waiting for these to shake out: ros/rosdistro#36888 ros/rosdistro#36893
Waiting for these to shake out: ros/rosdistro#36888 ros/rosdistro#36893
Waiting for these to shake out: ros/rosdistro#36888 ros/rosdistro#36893
- Fix CI Docker image namespace, following upstream [1] (possibly temporary) - Update CI Docker image and CI config to Humble/Jammy - Fix `clang-format` package name for Jammy - Update pre-commit GH action tag to latest 3.0.0 - Fix Cloudsmith.io repo install - Fix `python-attrs-pip` rosdep key while waiting on [2] and [3] [1]: moveit/moveit2#1908 [2]: ros/rosdistro#36888 [3]: ros/rosdistro#36893
Replace Ubuntu in the
python-attrs-pip
key, removed in commit 59517bc.