Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependency on 'rostopic' in 'rostest' package #1981

Closed
mateus-amarante opened this issue Jun 26, 2020 · 1 comment · Fixed by #2002
Closed

Missing dependency on 'rostopic' in 'rostest' package #1981

mateus-amarante opened this issue Jun 26, 2020 · 1 comment · Fixed by #2002

Comments

@mateus-amarante
Copy link
Contributor

rostest should exec_depend on rostopic because it is used in publishtest tool

@mateus-amarante
Copy link
Contributor Author

I have just realized rostopic is imported but not used, so it should not be an exec_depend. On the other hand, it should be a test dependency:

<node pkg="rostopic" type="rostopic" name="freq_topic_pub" args="pub /frequent_topic std_msgs/Bool 'data: false' -r 10" />
<node pkg="rostopic" type="rostopic" name="once_topic_pub" args="pub /once_topic std_msgs/Bool 'data: false' -1l" />

@mateus-amarante mateus-amarante changed the title Missing exec dependency on 'rostopic' in 'rostest' package Missing dependency on 'rostopic' in 'rostest' package Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant