Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows][melodic] Use C++14 [[deprecated]] for better portability #47

Merged
merged 1 commit into from
Mar 9, 2019
Merged

[Windows][melodic] Use C++14 [[deprecated]] for better portability #47

merged 1 commit into from
Mar 9, 2019

Conversation

seanyen
Copy link
Contributor

@seanyen seanyen commented Feb 25, 2019 •
edited
Loading

Use C++14 [[deprecated]] for better portability.

@bmagyar
Copy link
Member

bmagyar commented Feb 26, 2019

Nice catch!
One tiny note, this is actually C++14 but we are fine with that on Melodic AFAIK

@bmagyar bmagyar self-requested a review February 26, 2019 11:29
@seanyen seanyen changed the title [Windows][melodic] Use C++11 [[deprecated]] for better portability [Windows][melodic] Use C++14 [[deprecated]] for better portability Feb 26, 2019
@seanyen
Copy link
Contributor Author

seanyen commented Mar 4, 2019

@rhaschke Hi Robert, just happen to find out you are also the maintainer for srdfdom. It would be nice you can take a look this little portability code change for melodic. Thanks!

@rhaschke rhaschke merged commit 59c935b into moveit:melodic-devel Mar 9, 2019
@seanyen
Copy link
Contributor Author

seanyen commented Mar 9, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhaschke rhaschke rhaschke approved these changes

@bmagyar bmagyar bmagyar approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seanyen @bmagyar @rhaschke